fix: Filter resourceSamples on endpoints like on route #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
force-pushed
the
evan/cx-417-json-response-blurbs-for-specialized-devices-need-to-show
branch
from
738a65c to
0242f87
Compare
razor-x
force-pushed
the
evan/cx-417-json-response-blurbs-for-specialized-devices-need-to-show
branch
from
0242f87 to
5da951f
Compare
|
@razor-x this PR looks like it's working as intended, no? It re-uses the same filter in api-route.ts instead of the current selection for the sample, which is just selecting the first one: api-endpoint.ts const sample = resource.resourceSamples[0]
if (sample == null) return [] |
…ized-devices-need-to-show
mikewuu
approved these changes
Jul 21, 2025
…ized-devices-need-to-show
@mikewuu the issue is that this did not filter the sample as expected, hence I must be missing something. On this page the sample should be the thermostat not the lock https://docs.seam.co/latest/api/thermostats/list |
* include parent metadata * ci: Generate docs * update to only select parent metadata * ci: Generate docs * fallback endpoint sample * ci: Generate docs --------- Co-authored-by: Seam Bot <[email protected]>
mikewuu
deleted the
evan/cx-417-json-response-blurbs-for-specialized-devices-need-to-show
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.